gmp/jni
2
0
Fork 1
Code Issues 1 Pull Requests 1 Wiki Activity

jni: release string characters in conversion to Go string #14

Open
whereswaldon wants to merge 1 commits from whereswaldon/jni:waldon-13-fix-buf-leak into master
pull from: whereswaldon/jni:waldon-13-fix-buf-leak
merge into: gmp:master
Conversation 0 Commits 1 Files Changed 3 +9
whereswaldon commented 2025-12-30 09:44:47 -05:00
Contributor
Copy Link

This change should fix #13 by releasing the string buffer from the JVM after we
convert the string to a Go string. However, I've been having a lot of trouble
building the tests on Linux, and I've run out of time to keep messing with it.
I'm posting this patch in the hope that someone else is better positioned to
validate it. Please do not merge this unless you can verify that it works
properly.

Signed-off-by: Chris Waldon christopher.waldon.dev@gmail.com

This change should fix #13 by releasing the string buffer from the JVM after we convert the string to a Go string. However, I've been having a lot of trouble building the tests on Linux, and I've run out of time to keep messing with it. I'm posting this patch in the hope that someone else is better positioned to validate it. Please do not merge this unless you can verify that it works properly. Signed-off-by: Chris Waldon <christopher.waldon.dev@gmail.com>
whereswaldon added 1 commit 2025-12-30 09:44:47 -05:00 
This change should fix #13 by releasing the string buffer from the JVM after we
convert the string to a Go string. However, I've been having a lot of trouble
building the tests on Linux, and I've run out of time to keep messing with it.
I'm posting this patch in the hope that someone else is better positioned to
validate it. Please do not merge this unless you can verify that it works
properly.

Signed-off-by: Chris Waldon <christopher.waldon.dev@gmail.com>
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u waldon-13-fix-buf-leak:whereswaldon-waldon-13-fix-buf-leak
git checkout whereswaldon-waldon-13-fix-buf-leak

Merge

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff whereswaldon-waldon-13-fix-buf-leak
git checkout master
git merge --ff-only whereswaldon-waldon-13-fix-buf-leak
git checkout whereswaldon-waldon-13-fix-buf-leak
git rebase master
git checkout master
git merge --no-ff whereswaldon-waldon-13-fix-buf-leak
git checkout master
git merge --squash whereswaldon-waldon-13-fix-buf-leak
git checkout master
git merge --ff-only whereswaldon-waldon-13-fix-buf-leak
git checkout master
git merge whereswaldon-waldon-13-fix-buf-leak
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gmp/jni#14
No description provided.
Delete Branch "whereswaldon/jni:waldon-13-fix-buf-leak"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?