gmp/jni
2
0
Fork 3
Code Issues Pull Requests Wiki Activity

Enable resolving the values of static fields on classes #1

Merged
gmp merged 1 commits from whereswaldon/jni:master into master 2020-06-22 12:38:36 -04:00
Conversation 0 Commits 1 Files Changed 3 +156
whereswaldon commented 2020-06-20 12:09:30 -04:00
Contributor
Copy Link

I have tested that this works for int values, but that was essentially the only reason that I needed this capability. I suspect the other implementations work though, since their logic is essentially the same. The only potentially problematic issue would be if Java and Go use different floating point binary representations.

I have some ideas going forward about how to write unit tests for this package, but I wasn't able to get to it just now. If you'd prefer to wait to merge this until I can prove that the other functions work, I'm fine with that.

I have tested that this works for `int` values, but that was essentially the only reason that I needed this capability. I suspect the other implementations work though, since their logic is essentially the same. The only potentially problematic issue would be if Java and Go use different floating point binary representations. I have some ideas going forward about how to write unit tests for this package, but I wasn't able to get to it just now. If you'd prefer to wait to merge this until I can *prove* that the other functions work, I'm fine with that.
gmp closed this pull request 2020-06-22 12:38:35 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gmp/jni#1
No description provided.
Delete Branch "whereswaldon/jni:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?