gmp/ohlc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Format dates in the exchange timezone; sort and dedup events #1

Merged
gmp merged 1 commits from tz-and-event-ordering into main 2026-08-31 19:28:50 -04:00
Conversation 0 Commits 1 Files Changed 1 +149 -81
gmp commented 2026-08-31 19:28:36 -04:00
Owner
Copy Link
  • Dates were formatted with time.Unix (machine local zone), shifting the
    trading day by one for any exchange in a different timezone. Use
    meta.exchangeTimezoneName (IANA), falling back to meta.gmtoffset,
    then UTC.
  • Dividend/capital-gain/split CSVs were emitted in random order (JSON
    object iteration). Sort rows by date.
  • Yahoo occasionally emits the same chart timestamp twice; keep the
    last occurrence (this drops the spurious CVSIX 2008-12-18 0.292 row
    whose date is duplicated by the real 0.641 distribution).
  • nil volume no longer panics (prints 0).
  • Missing dividend/cap-gain amount still reports an error.
- Dates were formatted with time.Unix (machine local zone), shifting the trading day by one for any exchange in a different timezone. Use meta.exchangeTimezoneName (IANA), falling back to meta.gmtoffset, then UTC. - Dividend/capital-gain/split CSVs were emitted in random order (JSON object iteration). Sort rows by date. - Yahoo occasionally emits the same chart timestamp twice; keep the last occurrence (this drops the spurious CVSIX 2008-12-18 0.292 row whose date is duplicated by the real 0.641 distribution). - nil volume no longer panics (prints 0). - Missing dividend/cap-gain amount still reports an error.
gmp added 1 commit 2026-08-31 19:28:37 -04:00 
- Dates were formatted with time.Unix (machine local zone), shifting the
  trading day by one for any exchange in a different timezone. Use
  meta.exchangeTimezoneName (IANA), falling back to meta.gmtoffset,
  then UTC.
- Dividend/capital-gain/split CSVs were emitted in random order (JSON
  object iteration). Sort rows by date.
- Yahoo occasionally emits the same chart timestamp twice; keep the
  last occurrence (this drops the spurious CVSIX 2008-12-18 0.292 row
  whose date is duplicated by the real 0.641 distribution).
- nil volume no longer panics (prints 0).
- Missing dividend/cap-gain amount still reports an error.
gmp merged commit 584ec8753c into main 2026-08-31 19:28:50 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gmp/ohlc#1
No description provided.
Delete Branch "tz-and-event-ordering"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?