gmp/jni
2
0
Fork 3
Code Issues Pull Requests Wiki Activity

Implement calling static boolean methods #5

Closed
whereswaldon wants to merge 0 commits from whereswaldon/jni:master into master
pull from: whereswaldon/jni:master
merge into: gmp:master
Conversation 2 Commits - Files Changed -
whereswaldon commented 2021-04-18 14:42:34 -04:00
Contributor
Copy Link

My last PR was based on an out-of-date branch, and I couldn't seem to make GOGS update the branch after I rebased. This is basically the same changeset, but without merge conflicts. Supercedes #4

My last PR was based on an out-of-date branch, and I couldn't seem to make GOGS update the branch after I rebased. This is basically the same changeset, but without merge conflicts. Supercedes #4
gmp commented 2021-04-30 09:57:34 -04:00
Owner
Copy Link

+jint _jni_CallStaticBooleanMethodA(JNIEnv *env, jclass cls, jmethodID method, jvalue *args) {

  • return (*env)->CallStaticBooleanMethodA(env, cls, method, args);
    +}

Shouldn't this return jboolean, not jint?

> +jint _jni_CallStaticBooleanMethodA(JNIEnv *env, jclass cls, jmethodID method, jvalue *args) { > + return (*env)->CallStaticBooleanMethodA(env, cls, method, args); > +} Shouldn't this return jboolean, not jint?
whereswaldon commented 2021-06-09 16:09:37 -04:00
Author
Contributor
Copy Link

Closing as Gitea says this PR is "broken due to missing fork information"

Closing as Gitea says this PR is "broken due to missing fork information"
whereswaldon closed this pull request 2021-06-09 16:09:37 -04:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gmp/jni#5
No description provided.
Delete Branch "whereswaldon/jni:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?