gallery/vendor/i-slint-core/textlayout/sharedparley/shaping.rs
Greg Pomerantz 2f4768f354 Fix 120Hz scroll jank end-to-end: render-ahead present + full-cache eviction off the UI thread
Three root causes, all fixed and verified on the Pixel 9 Pro:

1. Present phase (backend + renderer): VSYNC_LOCKED_RENDER defers the
   render to the vsync wake; RENDER_AHEAD presents the previous frame at
   the start of render() (phase = wake + ~1.1 ms) and holds the new
   frame one slot. Crash fix: a held wgpu frame must be PRESENTED, never
   merely dropped, before the next acquire (AlreadyAcquired panic at
   launch otherwise); discard_pending_frame presents too.

2. Full-res prefetch churn (src/lib.rs): the 8-slot full cache cycled
   through a ~20-cell viewport forever (137 decodes/20 s) and each
   eviction free()'d a 50 MB Vec on the UI thread (20-52 ms CPU spikes,
   ~7/s = the residual SLOWEV NonMain jank). Fix: 60 s tombstone
   cooldown on evicted paths (idle prefetch skips, urgent tap bypasses)
   + off-thread reaper for the freed blobs (insert: 21 ms -> 4 us).

3. (earlier) Skia final flush + Mailbox present mode (vendor, M3).

Instrumentation (all behind --features perf): OTHR/INVK/INVK_TAG/FLCK
lines for cross-thread closure timing and push-site tagging.

Warm measured swipe, 8580-file grid: cadence median 8.33 ms (exact
120 Hz), p99 15.5 ms, 5/552 gaps >16.7 ms (0.9%, max 28.3 ms, zero
>33 ms); PRES phase median ~994 us, zero late frames. Docs updated
(docs/BUGS/scroll-jank-120hz.md, full scorecard + line reference).

Also: vendored i-slint-core + wgpu-hal (vkshim interposition patch),
vkshim profiling tooling, backend made a non-optional dep, debuggable
flag for simpleperf (REMOVE before shipping).
2026-10-30 02:49:23 -04:00

402 lines
17 KiB
Rust

// Copyright © SixtyFPS GmbH <info@slint.dev>
// SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-Slint-Royalty-free-2.0 OR LicenseRef-Slint-Software-3.0
// cSpell: ignore uncacheable unrepresentable
//! From text to shaped paragraphs.
//!
//! Everything that ends up in a cache entry is produced here, and [`shape_paragraphs`] is the
//! one function it happens through: measuring and drawing must register identical cache
//! dependencies, so neither may shape through anything narrower.
use super::*;
/// Font size of inline `code` runs, as a fraction of the surrounding body
/// text. Matches the convention used by GitHub-style markdown renderers — the
/// glyphs sit a little smaller than body text, inside a translucent capsule
/// that visually marks them as code.
const INLINE_CODE_FONT_SCALE: f32 = 0.85;
std::thread_local! {
static LAYOUT_CONTEXT: RefCell<parley::LayoutContext<Brush>> = Default::default();
}
#[derive(Debug, Default, PartialEq, Clone, Copy)]
pub(super) struct Brush {
/// When set, this overrides the fill/stroke to use this color.
pub(super) override_fill_color: Option<Color>,
pub(super) stroke: Option<TextStrokeStyle>,
pub(super) link_color: Option<Color>,
}
pub(super) struct LayoutWithoutLineBreaksBuilder {
font_request: Option<FontRequest>,
pub(super) text_wrap: TextWrap,
stroke: Option<TextStrokeStyle>,
pub(super) scale_factor: ScaleFactor,
pub(super) pixel_size: LogicalLength,
/// When false, overlong words are not broken up. Only used to measure the
/// min-content width (the longest word), never to lay text out for display.
overflow_wrap_anywhere: bool,
}
impl LayoutWithoutLineBreaksBuilder {
pub(super) fn new(
font_request: Option<FontRequest>,
text_wrap: TextWrap,
stroke: Option<TextStrokeStyle>,
scale_factor: ScaleFactor,
) -> Self {
let pixel_size = font_request
.as_ref()
.and_then(|font_request| font_request.pixel_size)
.unwrap_or(DEFAULT_FONT_SIZE);
Self {
font_request,
text_wrap,
stroke,
scale_factor,
pixel_size,
overflow_wrap_anywhere: true,
}
}
fn ranged_builder<'a>(
&self,
layout_ctx: &'a mut parley::LayoutContext<Brush>,
font_ctx: &'a mut parley::FontContext,
text: &'a str,
) -> parley::RangedBuilder<'a, Brush> {
// Use the requested font's natural line-height ratio for every run so fallback fonts,
// such as the symbol font used for password characters, don't enlarge the line box.
// `FontSizeRelative` scales the result with each styled span's font size.
let line_height_ratio =
self.font_request.as_ref().and_then(|fr| line_height_ratio(font_ctx, fr));
let mut builder = layout_ctx.ranged_builder(font_ctx, text, self.scale_factor.get(), false);
if let Some(ratio) = line_height_ratio {
builder.push_default(parley::StyleProperty::LineHeight(
parley::style::LineHeight::FontSizeRelative(ratio),
));
}
if let Some(ref font_request) = self.font_request {
let mut fallback_family_iter = sharedfontique::FALLBACK_FAMILIES
.into_iter()
.map(parley::style::FontFamilyName::Generic);
let font_families: &[parley::style::FontFamilyName] = if let Some(family) =
&font_request.family
{
let mut iter =
core::iter::once(parley::style::FontFamilyName::named(family.as_str()))
.chain(fallback_family_iter);
&core::array::from_fn::<
_,
{ sharedfontique::FALLBACK_FAMILIES.as_slice().len() + 1 },
_,
>(|_| iter.next().unwrap())
} else {
&core::array::from_fn::<_, { sharedfontique::FALLBACK_FAMILIES.as_slice().len() }, _>(
|_| fallback_family_iter.next().unwrap(),
)
};
builder.push_default(parley::style::FontFamily::List(std::borrow::Cow::Borrowed(
font_families,
)));
if let Some(weight) = font_request.weight {
builder.push_default(parley::StyleProperty::FontWeight(
parley::style::FontWeight::new(weight as f32),
));
}
if let Some(letter_spacing) = font_request.letter_spacing {
builder.push_default(parley::StyleProperty::LetterSpacing(letter_spacing.get()));
}
builder.push_default(parley::StyleProperty::FontStyle(if font_request.italic {
parley::style::FontStyle::Italic
} else {
parley::style::FontStyle::Normal
}));
}
builder.push_default(parley::StyleProperty::FontSize(self.pixel_size.get()));
builder.push_default(parley::StyleProperty::WordBreak(match self.text_wrap {
TextWrap::NoWrap => parley::style::WordBreak::KeepAll,
TextWrap::WordWrap => parley::style::WordBreak::Normal,
TextWrap::CharWrap => parley::style::WordBreak::BreakAll,
}));
builder.push_default(parley::StyleProperty::OverflowWrap(
match (self.text_wrap, self.overflow_wrap_anywhere) {
(TextWrap::NoWrap, _) | (_, false) => parley::style::OverflowWrap::Normal,
(TextWrap::WordWrap | TextWrap::CharWrap, true) => {
parley::style::OverflowWrap::Anywhere
}
},
));
if self.text_wrap == TextWrap::NoWrap {
// Parley 0.9 removed the width parameter from `Layout::align()` and instead
// uses the `max_advance` set by `break_all_lines()` as the alignment container
// width. To allow passing `max_physical_width` to `break_all_lines` for alignment
// purposes without triggering actual line wrapping, we must set `TextWrapMode::NoWrap`.
builder.push_default(parley::StyleProperty::TextWrapMode(
parley::style::TextWrapMode::NoWrap,
));
}
builder.push_default(parley::StyleProperty::Brush(Brush {
override_fill_color: None,
stroke: self.stroke,
link_color: None,
}));
builder
}
/// Note that the selection is deliberately absent here: it is a rendering concern, not a
/// styling one, and baking it into the layout both makes the layout uncacheable across
/// selection changes and makes sub-glyph selection boundaries unrepresentable. See
/// [`SelectionSpan`].
pub(super) fn build(
&self,
font_context: &mut parley::FontContext,
text: &str,
formatting: impl IntoIterator<Item = i_slint_common::styled_text::FormattedSpan>,
link_color: Option<Color>,
) -> parley::Layout<Brush> {
use i_slint_common::styled_text::Style;
LAYOUT_CONTEXT.with_borrow_mut(|layout_ctx| {
let mut builder = self.ranged_builder(layout_ctx, font_context, text);
// filter empty ranges otherwise parley will panic on assert
for span in formatting.into_iter().filter(|s| !s.range.is_empty()) {
match span.style {
Style::Emphasis => {
builder.push(
parley::StyleProperty::FontStyle(parley::style::FontStyle::Italic),
span.range,
);
}
Style::Strikethrough => {
builder.push(parley::StyleProperty::Strikethrough(true), span.range);
}
Style::Strong => {
builder.push(
parley::StyleProperty::FontWeight(parley::style::FontWeight::BOLD),
span.range,
);
}
Style::Code => {
builder.push(
parley::StyleProperty::FontFamily(parley::style::FontFamily::Single(
parley::style::FontFamilyName::Generic(
parley::style::GenericFamily::Monospace,
),
)),
span.range.clone(),
);
// Inline `code` reads as slightly smaller text on top of a
// translucent capsule (drawn separately in `TextParagraph::draw`),
// matching the convention used by common markdown renderers.
builder.push(
parley::StyleProperty::FontSize(
self.pixel_size.get() * INLINE_CODE_FONT_SCALE,
),
span.range,
);
}
Style::Underline => {
builder.push(parley::StyleProperty::Underline(true), span.range);
}
Style::Link => {
builder.push(parley::StyleProperty::Underline(true), span.range.clone());
builder.push(
parley::StyleProperty::Brush(Brush {
override_fill_color: None,
stroke: self.stroke,
link_color,
}),
span.range,
);
}
Style::Color(color) => {
builder.push(
parley::StyleProperty::Brush(Brush {
override_fill_color: Some(crate::Color::from_argb_encoded(color)),
stroke: self.stroke,
link_color: None,
}),
span.range,
);
}
}
}
builder.build(text)
})
}
}
/// The line-height ratio, relative to the font size, that every shaped line gets.
pub(super) fn line_height_ratio(
font_ctx: &mut parley::FontContext,
font_request: &FontRequest,
) -> Option<f32> {
let font = font_request.query_fontique(&mut font_ctx.collection, &mut font_ctx.source_cache)?;
let face = skrifa::FontRef::from_index(font.blob.data(), font.index).ok()?;
let location = face.axes().location(font.synthesis.variation_settings());
let metrics = face.metrics(skrifa::instance::Size::unscaled(), &location);
let units_per_em = metrics.units_per_em as f32;
(units_per_em > 0.0)
.then(|| (metrics.ascent - metrics.descent + metrics.leading) / units_per_em)
.map(|natural_ratio| {
font_request.line_height_for_natural_height(natural_ratio).unwrap_or(natural_ratio)
})
}
/// Splits plain text into paragraph byte ranges at `'\n'`. The `'\n'` and any preceding `'\r'`
/// are excluded from the range: parley treats a lone CR as a mandatory line break, so a CRLF
/// left in the paragraph would render an extra empty line.
pub(super) fn paragraph_ranges(text: &str) -> impl Iterator<Item = Range<usize>> + '_ {
let mut start = 0;
text.split('\n').map(move |paragraph| {
let end = start + paragraph.len();
let range = if paragraph.ends_with('\r') { start..end - 1 } else { start..end };
start = end + 1;
range
})
}
pub(super) fn create_text_paragraphs(
layout_builder: &LayoutWithoutLineBreaksBuilder,
font_context: &mut parley::FontContext,
text: PlainOrStyledText,
link_color: Color,
) -> Vec<TextParagraph> {
let paragraph_from_text =
|font_context: &mut parley::FontContext,
text: &str,
range: std::ops::Range<usize>,
formatting: Vec<i_slint_common::styled_text::FormattedSpan>,
links: Vec<(std::ops::Range<usize>, std::string::String)>| {
let code_ranges: alloc::vec::Vec<Range<usize>> = formatting
.iter()
.filter(|s| matches!(s.style, i_slint_common::styled_text::Style::Code))
.map(|s| s.range.clone())
.collect();
let layout = layout_builder.build(font_context, text, formatting, Some(link_color));
TextParagraph { range, y: PhysicalLength::default(), layout, links, code_ranges }
};
let mut paragraphs = Vec::with_capacity(1);
match text {
PlainOrStyledText::Plain(ref text) => {
for range in paragraph_ranges(text) {
paragraphs.push(paragraph_from_text(
font_context,
&text[range.clone()],
range,
Default::default(),
Default::default(),
));
}
}
PlainOrStyledText::Styled(rich_text) => {
for paragraph in rich_text.paragraphs {
paragraphs.push(paragraph_from_text(
font_context,
&paragraph.text,
0..0,
paragraph.formatting,
paragraph.links,
));
}
}
};
paragraphs
}
/// The builder the shaped paragraphs of `text` must be produced with. Measuring and drawing share
/// cache entries, so they have to agree on every input baked into the shaping -- which is why this
/// lives in one place rather than at each call site.
pub(super) fn shaping_builder(
text: Pin<&dyn crate::item_rendering::RenderString>,
item_rc: Option<&crate::item_tree::ItemRc>,
text_wrap: TextWrap,
scale_factor: ScaleFactor,
) -> LayoutWithoutLineBreaksBuilder {
let (stroke_brush, _, stroke_style) = text.stroke();
LayoutWithoutLineBreaksBuilder::new(
item_rc.map(|irc| text.font_request(irc)),
text_wrap,
(!stroke_brush.is_transparent()).then_some(stroke_style),
scale_factor,
)
}
/// The builder for measuring content widths, without an item to derive one from.
///
/// `WordWrap` gives `WordBreak::Normal`, so the min-content width becomes the longest word.
/// Content widths are intrinsic to the text, so they don't depend on the item's actual wrap mode.
/// `overflow_wrap_anywhere` is off because parley may otherwise break anywhere to keep overlong
/// words from overflowing, which would make the min-content width a single character instead of
/// the longest word.
pub(super) fn content_widths_builder(
font_request: FontRequest,
scale_factor: ScaleFactor,
) -> LayoutWithoutLineBreaksBuilder {
let mut builder = LayoutWithoutLineBreaksBuilder::new(
Some(font_request),
TextWrap::WordWrap,
None,
scale_factor,
);
builder.overflow_wrap_anywhere = false;
builder
}
/// A builder for tests, which have no item to derive one from. Everything else obtains its
/// builder through [`shaping_builder`] or [`content_widths_builder`], so that it cannot disagree
/// with what the item's cache entry was shaped with.
#[cfg(test)]
pub(super) fn plain_builder_for_tests() -> LayoutWithoutLineBreaksBuilder {
LayoutWithoutLineBreaksBuilder::new(None, TextWrap::NoWrap, None, ScaleFactor::new(1.0))
}
#[cfg(test)]
pub(super) fn wrap_builder_for_tests() -> LayoutWithoutLineBreaksBuilder {
LayoutWithoutLineBreaksBuilder::new(None, TextWrap::WordWrap, None, ScaleFactor::new(1.0))
}
/// Shapes `text` the way both the drawing and the measuring paths need it, so that they can share
/// one cache entry. `text_wrap` is passed separately because `text_size` measures the unwrapped
/// width of items that are otherwise wrapped.
pub(super) fn shape_paragraphs(
text: Pin<&dyn crate::item_rendering::RenderString>,
item_rc: Option<&crate::item_tree::ItemRc>,
text_wrap: TextWrap,
scale_factor: ScaleFactor,
font_context: &mut parley::FontContext,
) -> Vec<TextParagraph> {
let builder = shaping_builder(text, item_rc, text_wrap, scale_factor);
create_text_paragraphs(&builder, font_context, text.text(), text.link_color())
}
pub(super) struct TextParagraph {
pub(super) range: Range<usize>,
pub(super) y: PhysicalLength,
pub(super) layout: parley::Layout<Brush>,
pub(super) links: std::vec::Vec<(Range<usize>, std::string::String)>,
/// Byte ranges within the paragraph's text that carry `Style::Code`. Drawn with a
/// translucent rounded background by `draw` for visual parity with common markdown
/// renderers.
pub(super) code_ranges: std::vec::Vec<Range<usize>>,
}