Greg Pomerantz
2f4768f354
Three root causes, all fixed and verified on the Pixel 9 Pro: 1. Present phase (backend + renderer): VSYNC_LOCKED_RENDER defers the render to the vsync wake; RENDER_AHEAD presents the previous frame at the start of render() (phase = wake + ~1.1 ms) and holds the new frame one slot. Crash fix: a held wgpu frame must be PRESENTED, never merely dropped, before the next acquire (AlreadyAcquired panic at launch otherwise); discard_pending_frame presents too. 2. Full-res prefetch churn (src/lib.rs): the 8-slot full cache cycled through a ~20-cell viewport forever (137 decodes/20 s) and each eviction free()'d a 50 MB Vec on the UI thread (20-52 ms CPU spikes, ~7/s = the residual SLOWEV NonMain jank). Fix: 60 s tombstone cooldown on evicted paths (idle prefetch skips, urgent tap bypasses) + off-thread reaper for the freed blobs (insert: 21 ms -> 4 us). 3. (earlier) Skia final flush + Mailbox present mode (vendor, M3). Instrumentation (all behind --features perf): OTHR/INVK/INVK_TAG/FLCK lines for cross-thread closure timing and push-site tagging. Warm measured swipe, 8580-file grid: cadence median 8.33 ms (exact 120 Hz), p99 15.5 ms, 5/552 gaps >16.7 ms (0.9%, max 28.3 ms, zero >33 ms); PRES phase median ~994 us, zero late frames. Docs updated (docs/BUGS/scroll-jank-120hz.md, full scorecard + line reference). Also: vendored i-slint-core + wgpu-hal (vkshim interposition patch), vkshim profiling tooling, backend made a non-optional dep, debuggable flag for simpleperf (REMOVE before shipping).
42 lines
1.3 KiB
Rust
42 lines
1.3 KiB
Rust
// Copyright © SixtyFPS GmbH <info@slint.dev>
|
|
// SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-Slint-Royalty-free-2.0 OR LicenseRef-Slint-Software-3.0
|
|
|
|
use criterion::{Criterion, criterion_group, criterion_main};
|
|
use i_slint_core::string::SharedString;
|
|
|
|
const REFERENCE_NUMBER: &str = "2384.2345345345";
|
|
const RESULT_NUMBER: &str = "2384,2345345345";
|
|
|
|
fn string_replace(c: &mut Criterion) {
|
|
c.bench_function("string_replace", |b| {
|
|
b.iter(|| {
|
|
let string = SharedString::from(REFERENCE_NUMBER);
|
|
let string = string.replace('.', ",");
|
|
assert_eq!(string, RESULT_NUMBER);
|
|
});
|
|
});
|
|
}
|
|
|
|
fn string_replacen(c: &mut Criterion) {
|
|
c.bench_function("string_replacen", |b| {
|
|
b.iter(|| {
|
|
let string = SharedString::from(REFERENCE_NUMBER);
|
|
let string = string.replacen('.', ",", 1);
|
|
assert_eq!(string, RESULT_NUMBER);
|
|
});
|
|
});
|
|
}
|
|
|
|
fn string_replace_own_character(c: &mut Criterion) {
|
|
c.bench_function("string_replace_own_character", |b| {
|
|
b.iter(|| {
|
|
let mut string = SharedString::from(REFERENCE_NUMBER);
|
|
string.replace_characters('.', ',', 1);
|
|
assert_eq!(string, RESULT_NUMBER);
|
|
});
|
|
});
|
|
}
|
|
|
|
criterion_group!(benches, string_replace, string_replacen, string_replace_own_character);
|
|
criterion_main!(benches);
|