gallery/vendor/i-slint-core/data_transfer.rs
Greg Pomerantz 2f4768f354 Fix 120Hz scroll jank end-to-end: render-ahead present + full-cache eviction off the UI thread
Three root causes, all fixed and verified on the Pixel 9 Pro:

1. Present phase (backend + renderer): VSYNC_LOCKED_RENDER defers the
   render to the vsync wake; RENDER_AHEAD presents the previous frame at
   the start of render() (phase = wake + ~1.1 ms) and holds the new
   frame one slot. Crash fix: a held wgpu frame must be PRESENTED, never
   merely dropped, before the next acquire (AlreadyAcquired panic at
   launch otherwise); discard_pending_frame presents too.

2. Full-res prefetch churn (src/lib.rs): the 8-slot full cache cycled
   through a ~20-cell viewport forever (137 decodes/20 s) and each
   eviction free()'d a 50 MB Vec on the UI thread (20-52 ms CPU spikes,
   ~7/s = the residual SLOWEV NonMain jank). Fix: 60 s tombstone
   cooldown on evicted paths (idle prefetch skips, urgent tap bypasses)
   + off-thread reaper for the freed blobs (insert: 21 ms -> 4 us).

3. (earlier) Skia final flush + Mailbox present mode (vendor, M3).

Instrumentation (all behind --features perf): OTHR/INVK/INVK_TAG/FLCK
lines for cross-thread closure timing and push-site tagging.

Warm measured swipe, 8580-file grid: cadence median 8.33 ms (exact
120 Hz), p99 15.5 ms, 5/552 gaps >16.7 ms (0.9%, max 28.3 ms, zero
>33 ms); PRES phase median ~994 us, zero late frames. Docs updated
(docs/BUGS/scroll-jank-120hz.md, full scorecard + line reference).

Also: vendored i-slint-core + wgpu-hal (vkshim interposition patch),
vkshim profiling tooling, backend made a non-optional dep, debuggable
flag for simpleperf (REMOVE before shipping).
2026-10-30 02:49:23 -04:00

459 lines
18 KiB
Rust

// Copyright © SixtyFPS GmbH <info@slint.dev>
// SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-Slint-Royalty-free-2.0 OR LicenseRef-Slint-Software-3.0
//! Types and helpers related to the [`DataTransfer`] type, which implements type-indexed arbitrary
//! data transfer both within an application and between applications.
use alloc::rc::Rc;
use core::any::Any;
#[cfg(feature = "std")]
use crate::SharedVector;
use crate::{SharedString, api::Image};
#[cfg(feature = "ffi")]
pub mod ffi;
/// Hidden type to make `DataTransfer` smaller and easier to use in FFI.
///
/// In particular, `Image` is a different size depending on feature flags, so this
/// allows `DataTransfer` to have a normalized size no matter what flags are enabled.
#[derive(Default, Clone, PartialEq)]
struct DataTransferInner {
// TODO: Custom binary data providers with custom MIME types.
/// Special-cased support for images, as the precise implementation of transferring
/// images differs between platforms.
image: Option<Image>,
/// Special-cased support for plain text, as the precise implementation of transferring
/// text differs between platforms.
plain_text: Option<SharedString>,
/// Special-cased support for files, as platforms transfer them as URLs or
/// native path lists. Stored as local filesystem paths.
#[cfg(feature = "std")]
file_paths: Option<SharedVector<std::path::PathBuf>>,
}
/// `DataTransfer` abstracts over the various ways of transferring data within an application
/// and between applications.
///
/// The details will depend on the current platform, but the common features are:
///
/// - Each `DataTransfer` contains multiple views over the same data in different formats
/// - The `DataTransfer` may contain an in-memory representation of the data, which can be
/// sent and received within the current application
/// - Serializing to/deserializing from a given format may be done eagerly or lazily[^lazy-note]
///
/// [^lazy-note]: Platforms differ on which formats can and cannot be lazy, but all support it in
/// some capacity. Reading data from a `DataTransfer` cannot be assumed to be a cheap operation.
///
/// Currently, plain text, image data, and file paths are supported. Precisely how this maps
/// to the backend will depend on platform and features. Work to expand this API is ongoing, see
/// [the tracking issue for drag-and-drop][dnd-tracking-issue] to follow its progress.
///
/// [dnd-tracking-issue]: https://github.com/slint-ui/slint/issues/1967
///
/// The easiest way to construct this type is with the [`Default`] implementation, followed
/// by [`set_plain_text`](DataTransfer::set_plain_text) or [`set_image`](DataTransfer::set_image).
/// There are also implementations of [`From<SharedString>`](SharedString) and [`From<Image>`](Image)
/// which construct a new `DataTransfer` using those methods respectively. The opposites of these
/// operations are [`plain_text`](DataTransfer::plain_text) and
/// [`image`](DataTransfer::image).
///
/// ```rust
/// # use i_slint_core::{DataTransfer, string::ToSharedString as _};
///
/// let message = "Hello, world!";
/// let data = DataTransfer::from(message.to_shared_string());
/// assert_eq!(data.plain_text().unwrap(), message);
/// ```
#[derive(Clone, Default)]
#[repr(C)]
pub struct DataTransfer {
/// Special-cased types. `Option<Rc>` to prevent allocating if this `DataTransfer`
/// only contains `user_data`.
inner: Option<Rc<DataTransferInner>>,
/// A custom in-memory value. No MIME type-based dispatch is done here - if the user
/// wants to store one of a set of possible values, they should store their own enum
/// and handle the dispatch themselves.
user_data: Option<Rc<dyn Any>>,
}
impl core::fmt::Debug for DataTransfer {
fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
let mut s = f.debug_struct("DataTransfer");
s.field("has_plain_text", &self.has_plain_text()).field("has_image", &self.has_image());
#[cfg(feature = "std")]
s.field("has_file_paths", &self.has_file_paths());
s.field("has_user_data", &self.user_data.is_some());
s.finish()
}
}
// `PartialEq` doesn't really make sense for `DataTransfer`, but since it's required for values
// that Slint interacts with, we can at least make a best-effort attempt. This will return true
// if `other` is an unmodified clone of `self`, but if any modification has been done to either
// value since cloning then this will return false even if the two values are semantically
// identical.
impl PartialEq for DataTransfer {
fn eq(&self, other: &Self) -> bool {
self.inner == other.inner
&& self.user_data.as_ref().map(Rc::as_ptr) == other.user_data.as_ref().map(Rc::as_ptr)
}
}
impl From<SharedString> for DataTransfer {
fn from(value: SharedString) -> Self {
let mut out = DataTransfer::default();
out.set_plain_text(value);
out
}
}
impl From<Image> for DataTransfer {
fn from(value: Image) -> Self {
let mut out = DataTransfer::default();
out.set_image(value);
out
}
}
/// An error which can occur while fetching data from a `DataTransfer`.
#[derive(Debug, Clone)]
#[non_exhaustive]
pub enum DataTransferError {
/// The type was not listed in the set of available MIME types.
TypeNotFound,
}
impl core::error::Error for DataTransferError {}
impl core::fmt::Display for DataTransferError {
fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
match self {
Self::TypeNotFound => {
write!(f, "Type not supplied by data transfer")
}
}
}
}
impl DataTransfer {
/// Sets an image to be transferred by this [`DataTransfer`].
///
/// The image can be read using [`image`](DataTransfer::image). If
/// you only need the [`DataTransfer`] to have an image representation, use
/// [`From<Image>`](Image).
///
/// Each [`DataTransfer`] can only have a single image set at once. If this
/// method is called multiple times, the previous image will be overwritten.
/// However, you can have, for example, both an image representation and a
/// plain text representation set simultaneously on the same [`DataTransfer`].
///
/// Passing a default-constructed `Image` clears the previously-set image
/// instead of storing it, so afterwards [`has_image`](DataTransfer::has_image)
/// returns `false`. If the resulting `DataTransfer` carries no plain text,
/// image, or user data, it compares equal to [`DataTransfer::default()`].
pub fn set_image(&mut self, image: Image) -> &mut Self {
if matches!(image.0, crate::ImageInner::None) {
self.clear_image();
} else {
Rc::make_mut(self.inner.get_or_insert_default()).image = Some(image);
}
self
}
/// Sets unstyled, basic text to be transferred by this [`DataTransfer`].
///
/// The image can be read using [`plain_text`](DataTransfer::plain_text).
/// If you only need the [`DataTransfer`] to have a plain text representation,
/// use [`From<SharedString>`](SharedString).
///
/// Each [`DataTransfer`] can only have a single plain text representation
/// set at once. If this method is called multiple times, the previous text
/// will be overwritten. However, you can have, for example, both an image
/// representation and a plain text representation set simultaneously on the
/// same [`DataTransfer`].
///
/// Passing an empty string clears the previously-set plain text instead of
/// storing it, so afterwards [`has_plain_text`](DataTransfer::has_plain_text)
/// returns `false`. If the resulting `DataTransfer` carries no plain text,
/// image, or user data, it compares equal to [`DataTransfer::default()`].
pub fn set_plain_text(&mut self, plain_text: SharedString) -> &mut Self {
if plain_text.is_empty() {
self.clear_plain_text();
} else {
Rc::make_mut(self.inner.get_or_insert_default()).plain_text = Some(plain_text);
}
self
}
/// Sets a list of local file paths to be transferred by this [`DataTransfer`],
/// overwriting any previously set list. An empty list clears the file paths.
/// The paths can be read using [`file_paths`](DataTransfer::file_paths).
///
/// ```rust
/// # use i_slint_core::DataTransfer;
/// let mut transfer = DataTransfer::default();
/// transfer.set_file_paths(["/home/user/a.txt", "/home/user/b.png"]);
/// ```
#[cfg(feature = "std")]
pub fn set_file_paths<I>(&mut self, file_paths: I) -> &mut Self
where
I: IntoIterator,
I::Item: AsRef<std::path::Path>,
{
self.set_file_paths_vec(
file_paths.into_iter().map(|path| path.as_ref().to_path_buf()).collect(),
);
self
}
/// `set_file_paths` on the internal representation, for the FFI layer.
#[cfg(feature = "std")]
fn set_file_paths_vec(&mut self, file_paths: SharedVector<std::path::PathBuf>) {
if file_paths.is_empty() {
self.clear_file_paths();
} else {
Rc::make_mut(self.inner.get_or_insert_default()).file_paths = Some(file_paths);
}
}
fn clear_image(&mut self) {
let Some(inner_rc) = self.inner.as_mut() else { return };
if inner_rc.image.is_some() {
Rc::make_mut(inner_rc).image = None;
}
self.release_empty_inner();
}
fn clear_plain_text(&mut self) {
let Some(inner_rc) = self.inner.as_mut() else { return };
if inner_rc.plain_text.is_some() {
Rc::make_mut(inner_rc).plain_text = None;
}
self.release_empty_inner();
}
#[cfg(feature = "std")]
fn clear_file_paths(&mut self) {
let Some(inner_rc) = self.inner.as_mut() else { return };
if inner_rc.file_paths.is_some() {
Rc::make_mut(inner_rc).file_paths = None;
}
self.release_empty_inner();
}
/// Drops the inner allocation when nothing is stored in it, so that a fully
/// cleared transfer compares equal to `DataTransfer::default()`.
fn release_empty_inner(&mut self) {
if self.inner.as_ref().is_some_and(|inner| **inner == DataTransferInner::default()) {
self.inner = None;
}
}
/// Whether this transfer carries data another application could receive: plain text,
/// an image or file paths. User data stays within the process, so it doesn't count.
///
/// Reads the payload as a whole rather than testing each kind, so a payload added to
/// [`DataTransferInner`] later counts without touching the callers.
pub(crate) fn has_native_data(&self) -> bool {
self.inner.is_some()
}
/// Returns `true` if this data transfer advertises that it is readable as an [`Image`].
///
/// This does not necessarily mean that `image` will return `Ok`, as an I/O error
/// may occur.
pub fn has_image(&self) -> bool {
self.inner.as_ref().is_some_and(|inner| inner.image.is_some())
}
/// Returns `true` if this data transfer advertises that it is readable as plain text.
///
/// This does not necessarily mean that `plain_text` will return `Ok`, as an I/O
/// error may occur.
pub fn has_plain_text(&self) -> bool {
self.inner.as_ref().is_some_and(|inner| inner.plain_text.is_some())
}
/// Returns `true` if this data transfer advertises that it is readable as a list
/// of file paths.
///
/// This does not necessarily mean that `file_paths` will return `Ok`, as an I/O
/// error may occur.
#[cfg(feature = "std")]
pub fn has_file_paths(&self) -> bool {
self.inner.as_ref().is_some_and(|inner| inner.file_paths.is_some())
}
/// Returns `true` if this data transfer carries no data: no plain text, no image,
/// no file paths, and no user data. A `DataTransfer` constructed via
/// [`Default::default`] is empty.
pub fn is_empty(&self) -> bool {
// `release_empty_inner` keeps `inner` at `None` whenever it stores nothing.
self.inner.is_none() && self.user_data.is_none()
}
/// Set the application-internal data represented by this [`DataTransfer`].
/// This can be read with [`DataTransfer::user_data`], and allows circumventing
/// serialize/deserializing the data to bytes when a drag-and-drop or copy-paste
/// operation stays within the application.
pub fn set_user_data(&mut self, value: Rc<dyn Any>) -> &mut Self {
self.user_data = Some(value);
self
}
/// Helper to read this [`DataTransfer`] as plain text, supporting multiple encodings.
///
/// The caller should assume that this method call may do I/O.
pub fn plain_text(&self) -> Result<SharedString, DataTransferError> {
self.inner
.as_ref()
.and_then(|inner| inner.plain_text.clone())
.ok_or(DataTransferError::TypeNotFound)
}
/// Helper to read this [`DataTransfer`] as an image, supporting multiple image types.
///
/// The caller should assume that this method call may do I/O.
pub fn image(&self) -> Result<Image, DataTransferError> {
self.inner
.as_ref()
.and_then(|inner| inner.image.clone())
.ok_or(DataTransferError::TypeNotFound)
}
/// Helper to read this [`DataTransfer`] as a list of local file paths.
/// The returned iterator borrows this `DataTransfer`.
///
/// The caller should assume that this method call may do I/O.
#[cfg(feature = "std")]
pub fn file_paths(
&self,
) -> Result<impl Iterator<Item = &std::path::Path> + '_, DataTransferError> {
self.inner
.as_ref()
.and_then(|inner| inner.file_paths.as_ref())
.map(|paths| paths.iter().map(std::path::PathBuf::as_path))
.ok_or(DataTransferError::TypeNotFound)
}
/// Get the application-internal data represented by this [`DataTransfer`], if
/// one exists.
pub fn user_data(&self) -> Option<Rc<dyn Any>> {
self.user_data.clone()
}
}
#[cfg(test)]
mod tests {
use super::*;
use crate::graphics::{Rgba8Pixel, SharedPixelBuffer};
#[test]
fn set_plain_text_with_empty_string_clears() {
let mut dt = DataTransfer::default();
dt.set_plain_text("hello".into());
assert!(dt.has_plain_text());
dt.set_plain_text("".into());
assert!(!dt.has_plain_text());
assert!(dt.plain_text().is_err());
}
#[test]
fn set_image_with_default_image_clears() {
let mut dt = DataTransfer::default();
let buffer = SharedPixelBuffer::<Rgba8Pixel>::new(2, 2);
dt.set_image(Image::from_rgba8(buffer));
assert!(dt.has_image());
dt.set_image(Image::default());
assert!(!dt.has_image());
assert!(dt.image().is_err());
}
#[test]
fn set_plain_text_with_empty_string_on_default_stays_empty() {
let mut dt = DataTransfer::default();
dt.set_plain_text("".into());
assert!(!dt.has_plain_text());
assert!(dt.is_empty());
// The clear path on an already-default transfer must not allocate an
// inner Rc — otherwise it would compare unequal to `default()` even
// though both are observably empty.
assert!(dt.inner.is_none());
assert_eq!(dt, DataTransfer::default());
}
#[test]
fn set_image_with_default_image_on_default_stays_empty() {
let mut dt = DataTransfer::default();
dt.set_image(Image::default());
assert!(!dt.has_image());
assert!(dt.is_empty());
assert!(dt.inner.is_none());
assert_eq!(dt, DataTransfer::default());
}
#[test]
fn cleared_transfer_compares_equal_to_default() {
// After clearing every field, the inner Rc must be released so the
// transfer compares equal to a freshly-constructed default.
let mut dt = DataTransfer::default();
dt.set_plain_text("hello".into());
dt.set_image(Image::from_rgba8(SharedPixelBuffer::<Rgba8Pixel>::new(2, 2)));
dt.set_file_paths(["/tmp/a"]);
assert!(!dt.is_empty());
dt.set_plain_text("".into());
assert!(dt.inner.is_some(), "image and files still set, inner must remain");
dt.set_image(Image::default());
assert!(dt.inner.is_some(), "files still set, inner must remain");
dt.set_file_paths(core::iter::empty::<&str>());
assert!(dt.is_empty());
assert!(dt.inner.is_none());
assert_eq!(dt, DataTransfer::default());
}
#[test]
fn every_payload_counts_as_native_data() {
assert!(!DataTransfer::default().has_native_data());
for set in [
(|dt: &mut DataTransfer| {
dt.set_plain_text("hello".into());
}) as fn(&mut DataTransfer),
|dt| {
dt.set_image(Image::from_rgba8(SharedPixelBuffer::<Rgba8Pixel>::new(2, 2)));
},
|dt| {
dt.set_file_paths(["/tmp/a"]);
},
] {
let mut dt = DataTransfer::default();
set(&mut dt);
assert!(dt.has_native_data());
}
}
#[test]
fn set_file_paths_with_empty_list_clears() {
use std::path::Path;
use std::vec::Vec;
let mut dt = DataTransfer::default();
dt.set_file_paths(["/tmp/a", "/tmp/b"]);
assert!(dt.has_file_paths());
assert_eq!(
dt.file_paths().unwrap().collect::<Vec<_>>(),
[Path::new("/tmp/a"), Path::new("/tmp/b")]
);
dt.set_file_paths(core::iter::empty::<&str>());
assert!(!dt.has_file_paths());
assert!(dt.file_paths().is_err());
assert!(dt.inner.is_none());
assert_eq!(dt, DataTransfer::default());
}
}