Greg Pomerantz
2f4768f354
Three root causes, all fixed and verified on the Pixel 9 Pro: 1. Present phase (backend + renderer): VSYNC_LOCKED_RENDER defers the render to the vsync wake; RENDER_AHEAD presents the previous frame at the start of render() (phase = wake + ~1.1 ms) and holds the new frame one slot. Crash fix: a held wgpu frame must be PRESENTED, never merely dropped, before the next acquire (AlreadyAcquired panic at launch otherwise); discard_pending_frame presents too. 2. Full-res prefetch churn (src/lib.rs): the 8-slot full cache cycled through a ~20-cell viewport forever (137 decodes/20 s) and each eviction free()'d a 50 MB Vec on the UI thread (20-52 ms CPU spikes, ~7/s = the residual SLOWEV NonMain jank). Fix: 60 s tombstone cooldown on evicted paths (idle prefetch skips, urgent tap bypasses) + off-thread reaper for the freed blobs (insert: 21 ms -> 4 us). 3. (earlier) Skia final flush + Mailbox present mode (vendor, M3). Instrumentation (all behind --features perf): OTHR/INVK/INVK_TAG/FLCK lines for cross-thread closure timing and push-site tagging. Warm measured swipe, 8580-file grid: cadence median 8.33 ms (exact 120 Hz), p99 15.5 ms, 5/552 gaps >16.7 ms (0.9%, max 28.3 ms, zero >33 ms); PRES phase median ~994 us, zero late frames. Docs updated (docs/BUGS/scroll-jank-120hz.md, full scorecard + line reference). Also: vendored i-slint-core + wgpu-hal (vkshim interposition patch), vkshim profiling tooling, backend made a non-optional dep, debuggable flag for simpleperf (REMOVE before shipping).
62 lines
2.0 KiB
Rust
62 lines
2.0 KiB
Rust
use alloc::{boxed::Box, vec::Vec};
|
|
|
|
use crate::{
|
|
DeviceError, DynCommandBuffer, DynFence, DynResource, DynSurface, DynSurfaceTexture,
|
|
FenceValue, Queue, SurfaceError,
|
|
};
|
|
|
|
use super::DynResourceExt as _;
|
|
|
|
pub trait DynQueue: DynResource {
|
|
unsafe fn submit(
|
|
&self,
|
|
command_buffers: &[&dyn DynCommandBuffer],
|
|
surface_textures: &[&dyn DynSurfaceTexture],
|
|
signal_fence: (&dyn DynFence, FenceValue),
|
|
) -> Result<(), DeviceError>;
|
|
unsafe fn present(
|
|
&self,
|
|
surface: &dyn DynSurface,
|
|
texture: Box<dyn DynSurfaceTexture>,
|
|
) -> Result<(), SurfaceError>;
|
|
unsafe fn get_timestamp_period(&self) -> f32;
|
|
unsafe fn wait_for_idle(&self) -> Result<(), DeviceError>;
|
|
}
|
|
|
|
impl<Q: Queue + DynResource> DynQueue for Q {
|
|
unsafe fn submit(
|
|
&self,
|
|
command_buffers: &[&dyn DynCommandBuffer],
|
|
surface_textures: &[&dyn DynSurfaceTexture],
|
|
signal_fence: (&dyn DynFence, FenceValue),
|
|
) -> Result<(), DeviceError> {
|
|
let command_buffers = command_buffers
|
|
.iter()
|
|
.map(|cb| (*cb).expect_downcast_ref())
|
|
.collect::<Vec<_>>();
|
|
let surface_textures = surface_textures
|
|
.iter()
|
|
.map(|surface| (*surface).expect_downcast_ref())
|
|
.collect::<Vec<_>>();
|
|
let signal_fence = (signal_fence.0.expect_downcast_ref(), signal_fence.1);
|
|
unsafe { Q::submit(self, &command_buffers, &surface_textures, signal_fence) }
|
|
}
|
|
|
|
unsafe fn present(
|
|
&self,
|
|
surface: &dyn DynSurface,
|
|
texture: Box<dyn DynSurfaceTexture>,
|
|
) -> Result<(), SurfaceError> {
|
|
let surface = surface.expect_downcast_ref();
|
|
unsafe { Q::present(self, surface, texture.unbox()) }
|
|
}
|
|
|
|
unsafe fn get_timestamp_period(&self) -> f32 {
|
|
unsafe { Q::get_timestamp_period(self) }
|
|
}
|
|
|
|
unsafe fn wait_for_idle(&self) -> Result<(), DeviceError> {
|
|
unsafe { Q::wait_for_idle(self) }
|
|
}
|
|
}
|