The 19-26 ms mid-scroll stalls (Mali-only, fixed content offsets) were the Skia renderer's final synchronous GrDirectContext::flush() blocking the UI thread on Mali driver back-pressure — proven by per-stage timestamps in the vendored renderer (stall frames: flush 19-24 ms, walk 1-3 ms, 1 binding re-eval, image imports 0.1 ms each). - vendor/i-slint-renderer-skia (pinned 1.18.1, [patch.crates-io]): remove that one flush. Redundant on the wgpu backend: the surface already calls flush_and_submit before queue.present, same Vulkan queue, in-order. Phone: 0 stalls across 4 runs (max 3.6-7.4 ms vs the 8.3 ms budget), display verified clean. - docs/BUGS/slint-skia-final-flush-jank.md: full evidence, prior art (slint-ui/slint#12030 closest), open question for a future upstream filing (not filed yet). - Profiling also retired the O(n)-walk theory: Slint 1.18 prunes the item walk to ~133-152 items; the windowed Flickable built on that theory was already reverted (ListView is smooth with the fix). - Strip all jank-hunt instrumentation: FR/SCR/TICK/APLYD/STG logging, stg markers, .gallery_* file knobs, jsamp thread sampler, DbgScroll programmatic scroll, nblog perf-file mirroring. Also fixes the 'launches into unstoppable fast scroll' bug: a leftover .gallery_cmd was re-read on every launch (file never deleted) and overrode user swipes — the hook is gone. - Keep: nblog (logd backpressure is real), zero-dimension decode guards, keep-alive (default-off). - HANDOFF: replace stale windowed-Flickable section with the actual root cause/fix; 15 unit tests pass. Verified on phone (aarch64, 8580 photos) and emulator (x86_64).
147 lines
5.4 KiB
Rust
147 lines
5.4 KiB
Rust
// Copyright © SixtyFPS GmbH <info@slint.dev>
|
|
// SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-Slint-Royalty-free-2.0 OR LicenseRef-Slint-Software-3.0
|
|
|
|
use objc2::rc::Retained;
|
|
use objc2::runtime::ProtocolObject;
|
|
use objc2_metal::{MTLCommandQueue, MTLTexture};
|
|
use skia_safe::gpu::mtl;
|
|
|
|
use wgpu_29 as wgpu;
|
|
|
|
/// # Safety
|
|
/// `metal_handle` must be a valid Metal texture handle for the lifetime of the returned Surface.
|
|
unsafe fn wrap_metal_texture(
|
|
width: i32,
|
|
height: i32,
|
|
gr_context: &mut skia_safe::gpu::DirectContext,
|
|
metal_handle: mtl::Handle,
|
|
color_type: skia_safe::ColorType,
|
|
color_space: skia_safe::ColorSpace,
|
|
) -> Option<skia_safe::Surface> {
|
|
unsafe {
|
|
let texture_info = mtl::TextureInfo::new(metal_handle);
|
|
let backend_render_target =
|
|
skia_safe::gpu::backend_render_targets::make_mtl((width, height), &texture_info);
|
|
skia_safe::gpu::surfaces::wrap_backend_render_target(
|
|
gr_context,
|
|
&backend_render_target,
|
|
skia_safe::gpu::SurfaceOrigin::TopLeft,
|
|
color_type,
|
|
color_space,
|
|
None,
|
|
)
|
|
}
|
|
}
|
|
|
|
/// # Safety
|
|
/// The caller must ensure `texture` was created by a Metal-backed wgpu device and remains
|
|
/// valid for the lifetime of the returned `skia_safe::Surface`.
|
|
pub unsafe fn make_metal_surface(
|
|
gr_context: &mut skia_safe::gpu::DirectContext,
|
|
texture: &wgpu::Texture,
|
|
) -> Option<skia_safe::Surface> {
|
|
// SAFETY: texture is borrowed for the duration of this call; the Metal handle is copied
|
|
// into Skia's internal BackendRenderTarget via wrap_metal_texture.
|
|
unsafe {
|
|
let metal_texture = texture.as_hal::<wgpu::wgc::api::Metal>()?;
|
|
let handle =
|
|
metal_texture.raw_handle() as *const ProtocolObject<dyn MTLTexture> as mtl::Handle;
|
|
let size = texture.size();
|
|
let color_type = match texture.format() {
|
|
wgpu::TextureFormat::Bgra8Unorm => skia_safe::ColorType::BGRA8888,
|
|
wgpu::TextureFormat::Rgba8Unorm => skia_safe::ColorType::RGBA8888,
|
|
wgpu::TextureFormat::Rgba8UnormSrgb => skia_safe::ColorType::SRGBA8888,
|
|
_ => return None,
|
|
};
|
|
wrap_metal_texture(
|
|
size.width as i32,
|
|
size.height as i32,
|
|
gr_context,
|
|
handle,
|
|
color_type,
|
|
super::attachment_color_space(texture),
|
|
)
|
|
}
|
|
}
|
|
|
|
#[cfg_attr(not(feature = "unstable-wgpu-29"), allow(dead_code))]
|
|
pub unsafe fn import_metal_texture(
|
|
canvas: &skia_safe::Canvas,
|
|
texture: wgpu::Texture,
|
|
) -> Option<skia_safe::Image> {
|
|
unsafe {
|
|
let color_space = super::sampled_texture_color_space(&texture);
|
|
let metal_texture = texture.as_hal::<wgpu::wgc::api::Metal>();
|
|
|
|
let texture_info = mtl::TextureInfo::new(metal_texture.unwrap().raw_handle()
|
|
as *const ProtocolObject<dyn MTLTexture>
|
|
as mtl::Handle);
|
|
let size = texture.size();
|
|
|
|
let backend_texture = skia_safe::gpu::backend_textures::make_mtl(
|
|
(size.width as _, size.height as _),
|
|
skia_safe::gpu::Mipmapped::No,
|
|
&texture_info,
|
|
"Borrowed Metal texture",
|
|
);
|
|
Some(
|
|
skia_safe::image::Image::from_texture(
|
|
canvas.recording_context().as_mut().unwrap(),
|
|
&backend_texture,
|
|
skia_safe::gpu::SurfaceOrigin::TopLeft,
|
|
match texture.format() {
|
|
wgpu::TextureFormat::Rgba8Unorm => skia_safe::ColorType::RGBA8888,
|
|
wgpu::TextureFormat::Rgba8UnormSrgb => skia_safe::ColorType::SRGBA8888,
|
|
_ => return None,
|
|
},
|
|
skia_safe::AlphaType::Unpremul,
|
|
color_space,
|
|
)
|
|
.unwrap(),
|
|
)
|
|
}
|
|
}
|
|
|
|
pub fn set_layer_contents_gravity(surface: &wgpu::Surface<'_>) {
|
|
// SAFETY: The hal surface is only borrowed for the duration of this call, to adjust a
|
|
// CAMetalLayer property that wgpu itself neither reads nor writes.
|
|
unsafe {
|
|
if let Some(hal_surface) = surface.as_hal::<wgpu::wgc::api::Metal>() {
|
|
let layer = hal_surface.render_layer().lock();
|
|
let gravity = if !layer.contentsAreFlipped() {
|
|
objc2_quartz_core::kCAGravityTopLeft
|
|
} else {
|
|
objc2_quartz_core::kCAGravityBottomLeft
|
|
};
|
|
layer.setContentsGravity(gravity);
|
|
}
|
|
}
|
|
}
|
|
|
|
pub fn make_metal_context(
|
|
device: &wgpu::Device,
|
|
queue: &wgpu::Queue,
|
|
) -> Option<skia_safe::gpu::DirectContext> {
|
|
let backend = unsafe {
|
|
let maybe_metal_device = device.as_hal::<wgpu::wgc::api::Metal>();
|
|
let maybe_metal_queue = queue.as_hal::<wgpu::wgc::api::Metal>();
|
|
|
|
maybe_metal_device.and_then(|metal_device| {
|
|
let metal_device_raw = metal_device.raw_device();
|
|
|
|
maybe_metal_queue.map(|metal_queue| {
|
|
// Share wgpu's command queue with Skia, so that Metal's per-queue hazard tracking
|
|
// orders wgpu's texture writes before Skia samples them.
|
|
let metal_queue_raw: *const ProtocolObject<dyn MTLCommandQueue> =
|
|
metal_queue.as_raw();
|
|
mtl::BackendContext::new(
|
|
Retained::as_ptr(metal_device_raw) as mtl::Handle,
|
|
metal_queue_raw as mtl::Handle,
|
|
)
|
|
})
|
|
})?
|
|
};
|
|
|
|
skia_safe::gpu::direct_contexts::make_metal(&backend, None)
|
|
}
|